fix(rest): Added code for updating multiple project attachments. #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudra-superrr
added
needs code review
needs general test
|
Not working as expected. and please update the rest doc properly for this endpoint as both the parameter of the body is taking file type. The attachment paramter should be taking attachment required information. |
nikkuma7
force-pushed
the
fix/update_multiple_project_attachment
branch
2 times, most recently
from
1d8244a
to
6e7b6eb
Compare
nikkuma7
force-pushed
the
fix/update_multiple_project_attachment
branch
from
6e7b6eb
to
7452a02
Compare
|
The current endpoint returns the whole project in response and your endpoint response is empty. |
|
On uploading multiple files, all files having same attachment information. User should be able to change the attachment information(type, status, comment) with respect to each file. |
|
Please display some message if same file is uploaded again and also update the doc for this endpoint. |
nikkuma7
force-pushed
the
fix/update_multiple_project_attachment
branch
from
7452a02
to
f956f3c
Compare
nikkuma7
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
Signed-off-by: Nikesh kumar <[email protected]>
nikkuma7
force-pushed
the
fix/update_multiple_project_attachment
branch
from
f956f3c
to
84aad89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #2491
Description
Recently, we were able to upload a single file as an attachment, but after these code changes, we can now upload multiple files, including the same file or modified versions.
http://localhost:8080/resource/api/projects/{projectId}/attachments