add export SVG options #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sailingKieler @spoenemann Please check |
spoenemann
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Thanks! Have you tried whether the Map<String, String> is compatible with the definition in the client?
skipCopyStyles is a boolean, so it could be problematic because there's no conversion step of the received json action.
RequestModelAction has the same problem, but it could be that we never encountered it in practice because we used only string values.
spoenemann
reviewed
Jul 9, 2024
org.eclipse.sprotty/src/main/java/org/eclipse/sprotty/Actions.xtend
Outdated
Show resolved
Hide resolved
glatuske
force-pushed
the
add-export-svg-options
branch
from
7bd4931
to
7416e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make export SVG options available in Java backend