Draft
Conversation
ramceb
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
ramceb
force-pushed
the
mb_sphinx_toolchain
branch
from
8e11456 to
8515114
Compare
castler
reviewed
Apr 13, 2026
Comment on lines
+21
to
+23
| sphinx-needs | ||
| sphinx-design | ||
| sphinxcontrib-plantuml |
Contributor
There was a problem hiding this comment.
Do we not have any requirements for versions? At least some minimum or maximum version?
Contributor
|
Marking as draft, to indicate that this is work in progress. |
- Replace //visibility:public with //:__subpackages__ on sphinx_build py_binary and toolchain targets in bazel/toolchains/BUILD - Replace //visibility:public with //:__subpackages__ on all alias targets in third_party/sphinx/BUILD - Remove aspect_rules_py bazel_dep and its load() from MODULE.bazel and bazel/toolchains/BUILD; switch py_binary to rules_python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.