mw/com: add missing unit tests and enable build qnx 8#286
Open
ahmed0mousa wants to merge 2 commits intoeclipse-score:mainfrom
Open
mw/com: add missing unit tests and enable build qnx 8#286ahmed0mousa wants to merge 2 commits intoeclipse-score:mainfrom
ahmed0mousa wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
Contributor
ahmed0mousa
commented
Apr 10, 2026
ahmed0mousa
commented
- Add service_discovery_client_sequence_test to the BUILD file
- enable service_discovery_client_test to run on QNX 8
- Add service_discovery_client_sequence_test to the BUILD file - enable service_discovery_client_test to run on QNX 8
ahmed0mousa
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bemerybmw
reviewed
Apr 10, 2026
| ], | ||
| features = COMPILER_WARNING_FEATURES, | ||
| # TODO: Ticket-253098 | ||
| target_compatible_with = select({ |
Contributor
There was a problem hiding this comment.
You can remove the entire target_compatible_with
Contributor
There was a problem hiding this comment.
There are also some disabled tests which need to be reenabled. You can grep for 253098 to find them.
castler
added
the
test-qnx
castler
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
Contributor
|
We cannot merge this anyhow, without the QNX unit tests being enabled in our repo first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.