lola: Initialize method InArgs and Return values on creation#283
Open
lola: Initialize method InArgs and Return values on creation#283
Conversation
bemerybmw
force-pushed
the
brem_initialize_method_in_args
branch
from
7432a3b to
1f669d5
Compare
The binding dependent level allocates the type erased memory buffers on construction. These calls are not actually allocating anything but rather just returning pointers into the memory buffers. The binding independent layer is reponsible for keeping track of which in arg / return value can be accessed. Therefore, we rename these functions to better reflect what they're doing.
Previously, we were creating the type erased buffer for the InArgs and Return values and then reinterpreting the buffer as InArgs / Return values. This is UB and also means that non-trivially default constructible types were not properly initialized. We now explicitly call the constructors of each of these args.
bemerybmw
force-pushed
the
brem_initialize_method_in_args
branch
from
1f669d5 to
c70b44f
Compare
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were creating the type erased buffer for the InArgs and
Return values and then reinterpreting the buffer as InArgs / Return
values. This is UB and also means that non-trivially default
constructible types were not properly initialized. We now explicitly
call the constructors of each of these args.