Skip to content

GH-5442 Further optimize multi-threading performance and reduce copy operations in LmdbStore #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-5442 Further optimize multi-threading performance and reduce copy operations in LmdbStore #5443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c04a0ae
GH-5442 Further optimize multi-threading performance and reduce copy …
kenwenzel Sep 19, 2025
757cc5a
GH-5442 Optimize Varint by replacing multiple put calls with putShort…
kenwenzel Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/LmdbSailStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ void rollback() throws SailException {
if (tripleStoreException != null) {
throw wrapTripleStoreException();
} else {
Thread.yield();
Thread.onSpinWait();
}
}
} else {
Expand Down Expand Up @@ -478,7 +478,7 @@ public void flush() throws SailException {
if (tripleStoreException != null) {
throw wrapTripleStoreException();
} else {
Thread.yield();
Thread.onSpinWait();
}
}
}
Expand All @@ -491,7 +491,7 @@ public void flush() throws SailException {
if (tripleStoreException != null) {
throw wrapTripleStoreException();
} else {
Thread.yield();
Thread.onSpinWait();
}
}
}
Expand Down Expand Up @@ -676,30 +676,29 @@ private void startTransaction(boolean preferThreading) throws SailException {
} else if (Thread.interrupted()) {
throw new InterruptedException();
} else {
Thread.yield();
Thread.onSpinWait();
}
}
}

// keep thread running for at least 2ms to lock-free wait for the next
// keep thread running for a short while to lock-free wait for the next
// transaction
long start = 0;
while (running.get() && !nextTransactionAsync) {
if (start == 0) {
// System.currentTimeMillis() is expensive, so only call it when we
// are sure we need to wait
start = System.currentTimeMillis();
// only call System.nanoTime() if we need to wait
start = System.nanoTime();
}

if (System.currentTimeMillis() - start > 2) {
if (System.nanoTime() - start > 100000) {
synchronized (storeTxnStarted) {
if (!nextTransactionAsync) {
running.set(false);
return;
}
}
} else {
Thread.yield();
Thread.onSpinWait();
}
}
}
Expand Down Expand Up @@ -846,15 +845,15 @@ public void execute() throws Exception {
if (tripleStoreException != null) {
throw wrapTripleStoreException();
} else {
Thread.yield();
Thread.onSpinWait();
}
}

while (!removeOp.finished) {
if (tripleStoreException != null) {
throw wrapTripleStoreException();
} else {
Thread.yield();
Thread.onSpinWait();
}
}
return removeCount[0];
Expand Down Expand Up @@ -932,7 +931,7 @@ public CloseableIteration<? extends Statement> getStatements(Resource subj, IRI
try {
logger.warn("Failed to get statements, retrying", e);
// try once more before giving up
Thread.yield();
Thread.onSpinWait();
return createStatementIterator(txn, subj, pred, obj, explicit, contexts);
} catch (IOException e2) {
throw new SailException("Unable to get statements", e);
Expand Down
Loading
Loading