Skip to content

Use line ranges in compare editor by default#2565

Merged
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
iloveeclipse:issue_3776_line
Mar 13, 2026
Merged

Use line ranges in compare editor by default#2565
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
iloveeclipse:issue_3776_line

Conversation

@iloveeclipse
Copy link
Member

@github-actions
Copy link
Contributor

Test Results

    51 files   -   3      51 suites   - 3   35m 39s ⏱️ - 1m 26s
 4 546 tests ±  0   4 522 ✅ ±  0   23 💤 ±0  1 ❌ ±0 
12 081 runs   - 153  11 921 ✅  - 153  159 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 021e155. ± Comparison against base commit 2776d6f.

@iloveeclipse
Copy link
Member Author

artifacts/test-results-ubuntu-latest/resources/tests/org.eclipse.core.tests.resources/target/surefire-reports/TEST-org.eclipse.core.tests.resources.AutomatedResourceTests.xml [took 0s]
project 'P/a06e67f9e71e00111d63b712e335a2fb' is not expected to have nature: org.eclipse.core.tests.resources.earthNature
org.opentest4j.AssertionFailedError: project 'P/a06e67f9e71e00111d63b712e335a2fb' is not expected to have nature: org.eclipse.core.tests.resources.earthNature
	at org.eclipse.core.tests.resources.NatureTest.assertDoesNotHaveNature(NatureTest.java:125)
	at org.eclipse.core.tests.resources.NatureTest.testBug297871(NatureTest.java:311)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

!ENTRY org.eclipse.core.tests.resources 1 0 2026-03-13 14:21:49.577
!MESSAGE [NatureTest.testBug297871] setUp

!ENTRY org.eclipse.core.resources 2 2 2026-03-13 14:21:49.582
!MESSAGE Save operation warnings.
!SUBENTRY 1 org.eclipse.core.resources 2 234 2026-03-13 14:21:49.582
!MESSAGE The project description file (.project) for 'a06e67f9e71e00111d63b712e335a2fb' was missing.  This file contains important information about the project.  A new project description file has been created, but some information about the project may have been lost.

!ENTRY org.eclipse.core.tests.resources 1 0 2026-03-13 14:21:49.586
!MESSAGE [NatureTest.testBug297871] tearDown 

Test failure above is unrelated, only on Linux/Ubuntu machine, so must be unstable test.

@iloveeclipse iloveeclipse merged commit 8a99f8c into eclipse-platform:master Mar 13, 2026
20 of 22 checks passed
@iloveeclipse iloveeclipse deleted the issue_3776_line branch March 13, 2026 17:39
@HannesWell
Copy link
Member

While I find the new default visually appealing, it has one major functional draw-back:
For local changes the 'move'/undo buttons are not available:

Single line connection:
Image
'Range' connection:
Image

Without that the diff-view loses a tool, that at least I consider very important.
I assume these buttons can be added even for 'Range' connections, but until then I'm against making it the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve compare defaults

2 participants