Stabilize SortingTest match count#4177
Merged
akurtakov merged 1 commit intoJul 10, 2026
Merged
Conversation
Why mismatch: getMatchCount() can observe a different concurrent state than getElements()/getMatches() (cached count vs traversal), so the old comparison could race on Windows. Fix: derive baseline count from the same collected match snapshot used for allMatches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Member
Author
|
@trancexpress Do you have anything against merging this one ? |
Contributor
|
No, no objections, lets hope the sporadic fails are gone after this. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why mismatch: getMatchCount() can observe a different concurrent state than getElements()/getMatches() (cached count vs traversal), so the old comparison could race on Windows.
Fix: derive baseline count from the same collected match snapshot used for allMatches.
Should stabilize #3987