Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark deprecated and unsupported constants for deletion in #2581

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 4, 2024

IWorkbenchPreferenceConstants

Also remove initialization of unsupported preference values

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test Results

 1 214 files   -   607   1 214 suites   - 607   1h 20m 52s ⏱️ - 23m 4s
 7 728 tests ±    0   7 495 ✅  -     5  233 💤 +  5  0 ❌ ±0 
16 230 runs   - 8 115  15 716 ✅  - 7 882  514 💤  - 233  0 ❌ ±0 

Results for commit 4de3c17. ± Comparison against base commit f0e5533.

This pull request skips 5 tests.
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

♻️ This comment has been updated with latest results.

IWorkbenchPreferenceConstants

Also remove initialization of unsupported preference values
@vogella vogella force-pushed the workbench-initialization-mark-for-removal-depcreated-properties branch from 965e8e9 to 4de3c17 Compare December 7, 2024 16:55
@vogella
Copy link
Contributor Author

vogella commented Dec 9, 2024

Linux fail: #2603

@vogella vogella merged commit 5c65cbc into eclipse-platform:master Dec 9, 2024
10 of 13 checks passed
@vogella vogella deleted the workbench-initialization-mark-for-removal-depcreated-properties branch December 9, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant