Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply search results viewer limit to all levels of tree children. #2280

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Apply search results viewer limit to all levels of tree children. #2280

merged 2 commits into from
Sep 23, 2024

Conversation

raghucssit
Copy link
Contributor

Currently viewer limit is applied to top level elements. Object[] getChildren(Object parentElement) missing limit application.

see #2279

@raghucssit
Copy link
Contributor Author

@iloveeclipse FYI.

@iloveeclipse
Copy link
Member

@raghucssit : please in a dedicated commit bump org.eclipse.search bundle version.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 33m 46s ⏱️ - 10m 17s
 7 699 tests ±0   7 470 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 258 runs  ±0  23 510 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit e0fbc47. ± Comparison against base commit 8d647ea.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member

please in a dedicated commit bump org.eclipse.search bundle version.

Ping!

@raghucssit
Copy link
Contributor Author

please in a dedicated commit bump org.eclipse.search bundle version.

Ping!

Done.

@jukzi
Copy link
Contributor

jukzi commented Sep 17, 2024

i have doubts - How does this interact with this setting?
image

@iloveeclipse
Copy link
Member

i have doubts - How does this interact with this setting?

Good point, I believe we've overlooked that. We should check if we can change the text & if there are any other side effects. But I can confirm, that freezes are gone with the PR as it is. Also there were many other freezes by interacting with the original state, like clicking on expand/collapse results buttons would freeze everything forever...

@jukzi
Copy link
Contributor

jukzi commented Sep 17, 2024

I request that there is at most a single max items configuration per view. i.e. if a view has such a preference set, then it should not be overridden by the general preferences.

@iloveeclipse
Copy link
Member

I request that there is at most a single max items configuration per view. i.e. if a view has such a preference set, then it should not be overridden by the general preferences.

There is only one preference on your screenshot, and it is not overridden by any other.

@raghucssit
Copy link
Contributor Author

@iloveeclipse
Is it a good idea to rename the label in MatchFilterSelectionDialog ?
I also checked, this is not global preference. It is a search view filter settings only.

@iloveeclipse
Copy link
Member

@iloveeclipse Is it a good idea to rename the label in MatchFilterSelectionDialog ? I also checked, this is not global preference. It is a search view filter settings only.

Yes, it would match what we implement here.
So please change to Limit number of elements per level to:

@raghucssit
Apply search results viewer limit to all levels of tree children.
d2a0053 
Currently viewer limit is applied to top level elements. Object[]
getChildren(Object parentElement) missing limit application.

see eclipse-platform#2279
@raghucssit
Copy link
Contributor Author

@iloveeclipse Is it a good idea to rename the label in MatchFilterSelectionDialog ? I also checked, this is not global preference. It is a search view filter settings only.

Yes, it would match what we implement here. So please change to Limit number of elements per level to:

Fixed.

@iloveeclipse
Copy link
Member

@jukzi : any objections to merge?

@iloveeclipse iloveeclipse mentioned this pull request Sep 17, 2024
Merged
@iloveeclipse iloveeclipse merged commit 5af8f51 into eclipse-platform:master Sep 23, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raghucssit @iloveeclipse @jukzi