FindReplaceLogic: incremental doesn't skip over current selection #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wittmaxi
changed the title
|
This PR does not adhere to the specification introduced in #2104 (comment) anymore |
Wittmaxi
force-pushed
the
MW_incremental_search_same_word
branch
4 times, most recently
from
3932c36
to
0d748ed
Compare
|
Random Fail documented here. @HeikoKlare from my side, this is ready to merge |
Incremental search would start incremental search immediately after the current word. This meant that the incremental search would not go back to the word where the incremental search initially started. fixes eclipse-platform#2107
HeikoKlare
force-pushed
the
MW_incremental_search_same_word
branch
from
0d748ed
to
9b7a707
Compare
HeikoKlare
changed the title
HeikoKlare
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental search would start incremental search immediately after the
current word. This meant that the incremental search would not go back
to the word where the incremental search initially started.
fixes #2107