Skip to content

Commit

Permalink
Find/replace overlay: replace shell with integrated composite #2099
Browse files Browse the repository at this point in the history
The FindReplaceOverlay is currently realized as a separate shell (more
precisely, a JFace Dialog), which is placed at a proper position on top
of the workbench shell. This has some drawback:
- It has to manually adapt to movements of the parent shell or the
target part/widget
- It has to manually hide and show depending on visibility changes of
the target part/widget
- It does not follow events of the target immediately, i.e., movements
are always some milliseconds behind, minimize/maximize
operations/animations are not synchronous etc.
- It does not locate properly when the platform uses Wayland, as manual
shell positioning is not possible there

This change replaces the dialog-based implementation of the
FindReplaceOverlay with an in-place composite-based implementation. A
composite is created in the target widget and placed relative to this
composite. In consequence, the overlay automatically follows all move,
resize, hide/show operations of the target widget.

Fixes eclipse-platform/eclipse.platform.swt#1447

Fixes #2099

Fixes #2246
  • Loading branch information
HeikoKlare committed Oct 10, 2024
1 parent d50e66d commit 0c9a0b1
Show file tree
Hide file tree
Showing 3 changed files with 221 additions and 355 deletions.
Loading

0 comments on commit 0c9a0b1

Please sign in to comment.