Skip to content

Limit autoscale mode to quarter and exact only #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Limit autoscale mode to quarter and exact only #2771

wants to merge 2 commits into from
+59 −57

Conversation

@ShahzaibIbrahim
Copy link
Contributor

@ShahzaibIbrahim ShahzaibIbrahim commented Nov 12, 2025 •
edited
Loading

swt applications will be limited to use autoscale modes quarter and exact only otherwise user will see an error message stating the incompatibility. Also the tests testing other autoscale values have been removed.

This PR will further affect: eclipse-platform/eclipse.platform.ui#3475

This was referenced Nov 12, 2025
Merged
Draft
@ShahzaibIbrahim ShahzaibIbrahim linked an issue Nov 12, 2025 that may be closed by this pull request
Limit monitor-specific scaling to supported autoscale modes vi-eclipse/Eclipse-Platform#399
Open
@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as draft November 12, 2025 13:45
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

Test Results

  106 files   -  12    106 suites   - 12   9m 5s ⏱️ - 7m 46s
4 549 tests  - 103  4 530 ✅  - 104  17 💤  - 1  2 ❌ +2 
  260 runs   -  78    260 ✅  -  74   0 💤  - 4  0 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4ee56bc. ± Comparison against base commit d4ddd4c.

This pull request removes 103 tests. 
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…
This pull request skips 4 tests. 
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_getContentsBothClipboards
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_setContentsBothClipboards
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_FileTransfer ‑ test_nativeToJava
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell ‑ test_activateEventSend

♻️ This comment has been updated with latest results.

@ShahzaibIbrahim
Moving methods from Win32DPIUtil to DPIUtil for autoscaling
f01daf7 
Workbench needs few methods from DPIUtil that were only present for
Win32. Keeping the functionality for Win32DPIUtil as is, just making
them available for DPIUtil.
@ShahzaibIbrahim
Limit autoscale mode to quarter and exact only
4ee56bc 
swt applications will be limited to use autoscale modes quarter and
exact only otherwise user will see an error message stating the
incompatibility. Also the tests testing other autoscale values have been
removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limit monitor-specific scaling to supported autoscale modes

1 participant

@ShahzaibIbrahim