Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 11, 2025

This adds comprehensive documentation for AI agents and tools working with the Eclipse SWT codebase. The new AGENTS.md file includes:

  • Project overview and architecture details
  • Complete build instructions (Maven/Tycho and native libraries)
  • Repository structure and development workflows
  • Essential development rules (OSGi, resource disposal, UI threading)
  • Testing best practices and troubleshooting guidance
  • AI agent-specific guidelines

CLAUDE.md is updated to reference AGENTS.md, following the pattern used in eclipse.platform.ui repository.

🤖 Generated with Claude Code

Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename existing copilot instructions (any maybe adjust).

As AGENTS.MD is a standard I wonder why Claude is needing an own file?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Test Results

  118 files  ±0    118 suites  ±0   17m 19s ⏱️ +53s
4 652 tests ±0  4 634 ✅  - 1  18 💤 +1  0 ❌ ±0 
  338 runs  ±0    334 ✅ ±0   4 💤 ±0  0 ❌ ±0 

Results for commit 2e216ef. ± Comparison against base commit 8c5fcdd.

This pull request skips 1 test.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_setUrl_remote_with_post

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor Author

vogella commented Nov 11, 2025

Please rename existing copilot instructions (any maybe adjust).

I assume you mean delete? Copilot can use Agends.md directly

As AGENTS.MD is a standard I wonder why Claude is needing an own file?

I don't know why Claude does not follow the (new) standard. My assumption is that as the leading engine in code generation they play on their marketshare for code support and do not yet care about standards. It seems that standards are usually not pushed by the market leader. Just a personal opinion btw as I do not have insights in the Claude dev team.

@laeubi
Copy link
Contributor

laeubi commented Nov 11, 2025

I assume you mean delete? Copilot can use Agends.md directly

No why delete and replace with something else new? So rename it and maybe ask claude to update it if you think it is not sufficient enough. At least I have tested it already with this instructions and made sure they are working. So why would one want to start from scratch?

I don't know why Claude does not follow the (new) standard. My assumption is that as the leading engine in code generation they play on their marketshare for code support and do not yet care about standards.

For me a tool not following common practice can hardly be leading but anyways it sounds odd... so is there a issue/ticket for claude to support this in the future?

@vogella
Copy link
Contributor Author

vogella commented Nov 11, 2025

The new Agends.md file was created by on the copilot instruction so this request is already covered.

For me a tool not following common practice can hardly be leading

Yes, this never happened before, like IntelliJ not promoting LSP usage or MS Window ignoring standards ;-)

@laeubi
Copy link
Contributor

laeubi commented Nov 11, 2025

The new Agends.md file was created by on the copilot instruction so this request is already covered.

Why is the there no rename in this commit? I really don't want to go through and make a diff on my own.

So this should contain:

  • rename A > B
  • then changes on top of it to get a diff
  • add additional claude.md

otherwise its impossible to follow the history.

@vogella
Copy link
Contributor Author

vogella commented Nov 11, 2025

Ok, will update the PR once I find time.

@laeubi
Copy link
Contributor

laeubi commented Nov 13, 2025

Ok, will update the PR once I find time.

Thanks, I think unify this would be good think in general.

vogella and others added 3 commits November 14, 2025 01:19
This follows the AGENTS.md standard for AI tool documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Builds on original copilot-instructions.md with:
- Auto-generated file warnings (os.c, os_stats.*)
- Critical resource disposal rules (Color/Font auto-disposed)
- Threading requirements for SWT
- GTK function addition workflow
- OSGi bundle dependency notes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
This allows Claude Code to use the standard AGENTS.md documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants