Replacement of Image(device, int, int) constructor for Snippets #2722
+721
−724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-noori
force-pushed
the
al-noori/ReplaceWithImageGcDrawer
branch
2 times, most recently
from
587903b to
8b57522
Compare
al-noori
force-pushed
the
al-noori/ReplaceWithImageGcDrawer
branch
from
8b57522 to
c65368a
Compare
al-noori
force-pushed
the
al-noori/ReplaceWithImageGcDrawer
branch
7 times, most recently
from
2a42ddd to
33ac9ae
Compare
Contributor
Almost all usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards for the snippets. This replacement has/could not be made for the snippets {387, 215, 292, 95, 139} .
al-noori
force-pushed
the
al-noori/ReplaceWithImageGcDrawer
branch
from
33ac9ae to
aaab0b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes over a part to change all occurences of the
image(device, int, int)constructor with theimage(device, gc, int, int)constructor.All usages of the stated constructor are now replaced by an
ImageGcDrawerand theImage(device, gc int, int)constructor afterwards, for almost all the snippets. This replacement has/could not be made for the snippets {387, 215, 292, 95, 139}. The details for them are commented here: vi-eclipse/Eclipse-Platform#310 (comment).