[Refactor DPIUtil] rename scaleUp/Down #2314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaming scaleDown and ScaleUp methods to pixelToPoint and pointToPixel respectively
|
I tested the refactorings locally, and the changes look good to me. |
arunjose696
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming scaleDown and ScaleUp methods to pixelToPoint and pointToPixel respectively. The implementation detail (using a scale factor in body) doesn't clearly convey the intent of the method from its name. When someone (me) reads scaleDown(x) or scaleUp(x), the natural question is:
“Scaling relative to what? What coordinate system or unit is this about?”
That’s ambiguous without diving into the implementation.
In contrast, renaming to pixelToPoint(x) and pointToPixel(x) makes it immediately clear. We’re converting between pixel units (physical/screen space) and point units (logical/UI space). The direction of conversion is unambiguous.
The changes are done with Eclipse Refactoring tool. There are no manual changes.