Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI Indication for Unsaved Changes in Tabs #1632

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+76 −33
Draft

Improve UI Indication for Unsaved Changes in Tabs #1632

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5639d0c
Change rendering of dirty indicator in tabs - using a circle
schneidermic0 Nov 30, 2024
8f98355
Rename method to `isDirtyIndicatorShown()`
schneidermic0 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Rename method to isDirtyIndicatorShown()
@schneidermic0
schneidermic0 committed Jan 31, 2025
commit 8f9835592ac738b47ed51eff8cebc9d2dce467b9
6 changes: 3 additions & 3 deletions ...es/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabItem.java
View file
Original file line number Diff line number Diff line change
@@ -282,13 +282,13 @@ public boolean getShowClose() {
* Returns <code>true</code> to indicate that the dirty indicator should be shown.
* Otherwise return <code>false</code>.
*
* @return <code>true</code> if the dirty indicatorn should be shown
* @return <code>true</code> if the dirty indicator should be shown
*
* @since 3.129
*/
public boolean getShowDirty() {
public boolean isDirtyIndicatorShown() {
checkWidget();
return showClose;
return showDirty;
}

/**