Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build|RelEng] Clean-up and fix EnrichPom java code and fix warning #2741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Member

  • Move publish-to-maven project from Java-11 to 21 as the Maven-publication process already requires Java-21

  • Remove fix of scmConnection value as it's not necessary anymore (ECJ metadata are fine out of the box) and it removes (accidentally) the scm-tag information

  • Remove now obsolete SCM-mapping

  • Throw exceptions on missing information instead of using default and be strict

  • Remove unused enrichPoms.jardesc

@HannesWell HannesWell requested a review from merks January 11, 2025 19:09
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

- Move publish-to-maven project from Java-11 to 21 as the
Maven-publication process already requires Java-21
- Remove fix of scmConnection value as it's not necessary anymore (ECJ
metadata are fine out of the box) and it removes (accidentally) the
scm-tag information
- Remove now obsolete SCM-mapping
- Throw exceptions on missing information instead of using default and
be strict
- Add print-out about basic statics, i.e. the number of enhanced POM
files

- Remove unused enrichPoms.jardesc
@HannesWell HannesWell force-pushed the maven-publication-enrichPom-cleanup branch from 6d62e04 to be64d99 Compare January 12, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants