-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify nature checks and reuse existing constants from core.natures.PDE #941
Unify nature checks and reuse existing constants from core.natures.PDE #941
Conversation
2a5a5f3
to
940a8a9
Compare
I have now taken this as an opportunity to replace all occurrences of PDE nature and builder literals by the corresponding constants in the Additionally I moved the I also contemplate to rename the What's the opinion of the others? Keep one central class for all nature and builder ids and |
I would appreciate if we could delay such cleanups/unification until the pending PRs are merged so they don't get delayed/distorted by rebase conflicts, for me central classes tend to be convoluted by more and more unrelated stuff over time so I think keeping it on the project classes seems good. |
...pi.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/wizards/ApiToolingSetupWizardPage.java
Outdated
Show resolved
Hide resolved
@HannesWell still relevant? |
940a8a9
to
534e1d5
Compare
e8ea3a7
to
92378a0
Compare
Implemented that now which makes the PDE class obsolete since all methods and constants have been moved to the corresponding Now I just have to find out, why the tests are failing... |
eed8a92
to
5be7b7d
Compare
67d5009
to
46d8e9e
Compare
46d8e9e
to
e42e161
Compare
ad59edf
to
5f5f621
Compare
....eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/ApiBuilderTest.java
Outdated
Show resolved
Hide resolved
5f5f621
to
3052714
Compare
3052714
to
0e589ca
Compare
These quality-gates are really pedantic, but in the end that's good. And now finally the build is green. 🎉 |
No description provided.