Deploy PDE artifacts to maven #936

laeubi · 2023-11-27T07:51:16Z

As an alternative to

Create a p2 repo with PDE content #826

I think we maybe better should go the path of deploy PDE directly to the maven where we can consume than with maven target locations instead of create a new update site.

This has the following benefits:

No need to setup a download space and if we later decide its not good at all the snapshots get deleted after a while automatically
We can get more experience with this way of deployment and how it works out so PDE can become a blueprint for other projects to do so as well
This could be a first step to make it possible to release artifacts to central without the help of global deploy script
It would allow to see how deploying features to a maven repository works out

If this is in place, we can start to iron out the produced poms and start trying to strip PDE form the aggregator and instead consume it from the target.

FYI @HannesWell @akurtakov @mickaelistria @vogella

akurtakov · 2023-11-27T07:54:56Z

I fully support deploying to maven.
Having p2 repo is still mandatory IMO but one shouldn't block the other.

laeubi · 2023-11-27T07:57:27Z

Having p2 repo is still mandatory IMO but one shouldn't block the other.

You can have a p2 repo on maven as well, see https://github.com/eclipse-tycho/tycho/tree/master/demo/p2-maven-site

Beside that I think Eclipse/IBuild/SDK/Simrel/... will still include PDE anyways one way or another.

akurtakov · 2023-11-27T08:02:49Z

Having p2 repo is still mandatory IMO but one shouldn't block the other.

You can have a p2 repo on maven as well, see https://github.com/eclipse-tycho/tycho/tree/master/demo/p2-maven-site

Beside that I think Eclipse/IBuild/SDK/Simrel/... will still include PDE anyways one way or another.

So if SDK/I-builds want to include PDE without building it, you propose adding it as maven dependency. Can we say "latest" in maven deps somehow as I don't envision editing target file to pick latest PDE?

laeubi · 2023-11-27T08:09:01Z

So if SDK/I-builds want to include PDE without building it, you propose adding it as maven dependency

Yes

Can we say "latest" in maven deps somehow

Yes but it is deprecated.

I don't envision editing target file to pick latest PDE?

In the end PDE becomes a third party dep and we do updates for these as well, at best there the just one feature mentioned and one might even use a version range there, that especially the things we need to explore here how it works out and where we need better support or additional features to support such use-cases, but I strongly believe that platform should be leading here even though I know others are already using such setups.

github-actions · 2023-11-27T08:19:53Z

Test Results

    270 files ±0     270 suites ±0 46m 38s ⏱️ + 3m 52s
  3 327 tests ±0   3 297 ✔️ ±0 30 💤 ±0 0 ❌ ±0
10 278 runs ±0 10 188 ✔️ ±0 90 💤 ±0 0 ❌ ±0

Results for commit 0ddb87f. ± Comparison against base commit 3a696fb.

♻️ This comment has been updated with latest results.

laeubi · 2023-11-27T08:21:54Z

by the way I created https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3993 as it seems PDE is suffering build executors...

vogella · 2023-11-27T10:08:22Z

I fully support this approach, moving to a pure Maven build is also what a lot of my clients desire and if we use this approach it will help to stabilise the process. P2 update sites are often considered as "extra" or "Eclipse only" technologies by my clients which normally also have a lot of "regular" Maven projects and Maven knowledge.

laeubi · 2023-11-27T11:08:32Z

It seems some plugins use an older deploy plugin I have no clue why... will try to move this up otherwhise have to wait until master opens and maybe define it in the parent...

akurtakov · 2023-11-27T11:15:50Z

It seems some plugins use an older deploy plugin I have no clue why... will try to move this up otherwhise have to wait until master opens and maybe define it in the parent...

Please put it in the parent now. It's better to push such change now rather than multiplying it.

HannesWell

I fully support deploy PDE to a Maven-repo or maven central in a more direct and simple way and I'm happy to use it as a play ground to enhance that method further.

Nevertheless I also think that PDE should still also be provided through a p2 repo.
While I understand that some may like to get it through Maven I also assume that there is also a large user base that would like to obtain it through p2 as it is now.
But luckily we can do both so there is no need to choose. :)

It is to be discussed if PDE then gets its own p2-repo or will just continue to be provided through the existing eclipse/updates p2-repo.

And although it is actually not directly related to this PR and should be more discussed as part of eclipse-platform/eclipse.platform.releng.aggregator#1472: Even if PDE gets it own build there should be frequent builds of PDE against the latest versions of the other parts of the SDK, just like it is done at the moment with the I-builds. If PDE is still build as part of the nightly builds or a master build is triggered after a I-build, doesn't really matter. But I think it is important to have that since PDE usues many parts of other SDK areas that are not public API and may change at any time and we will only notice required actions quickly if we have frequent builds.

HannesWell · 2023-11-27T19:41:49Z

pom.xml

+        <pluginManagement>
+            <plugins>
+            </plugins>
+        </pluginManagement>


Looks unnecessary.

Suggested change

<pluginManagement>

<plugins>

</plugins>

</pluginManagement>

HannesWell · 2023-11-27T19:44:14Z

Jenkinsfile

 	stages {
 		stage('Build') {
 			steps {
 				wrap([$class: 'Xvnc', useXauthority: true]) {
 					sh '''
-						mvn clean verify --batch-mode -Dmaven.repo.local=$WORKSPACE/.m2/repository \
+						mvn clean ${MVN_GOALS} --batch-mode -Dmaven.repo.local=$WORKSPACE/.m2/repository \


If you convert this text-block to a GString block (i.e. by replacing leading and trailing ''' by """) you can probably inline the function call and save the indirection through the environment variable.

Suggested change

mvn clean ${MVN_GOALS} --batch-mode -Dmaven.repo.local=$WORKSPACE/.m2/repository \

mvn clean ${getMavenGoals()} --batch-mode -Dmaven.repo.local=$WORKSPACE/.m2/repository \

HannesWell · 2023-11-27T19:45:58Z

pom.xml

+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-deploy-plugin</artifactId>
+            <version>3.1.1</version>
+          </plugin>


Isn't this unnecessary with eclipse-platform/eclipse.platform.releng.aggregator#1582?

Suggested change

<plugin>

<groupId>org.apache.maven.plugins</groupId>

<artifactId>maven-deploy-plugin</artifactId>

<version>3.1.1</version>

</plugin>

mickaelistria · 2023-11-28T08:05:02Z

I also fully support deploying to Maven.
Just to make sure, are p2 metdata published with the artifacts? I think they must be published in general to handle cases where some p2.inf matters in the output installation.

mickaelistria · 2023-11-28T08:08:57Z

I think they must be published in general to handle cases where some p2.inf matters in the output installation.

Actually, if the p2.inf is included in the artifact and is honored later by the PDE target resolution, and by Tycho target resolution and by p2-maven-site, there seems to be no need to store them in Maven repo as they can be inferred later.
@laeubi Can you confirm that embedded p2.inf are honored by those consumers?

laeubi · 2023-11-28T08:50:10Z

Just to make sure, are p2 metdata published with the artifacts? I think they must be published in general to handle cases where some p2.inf matters in the output installation.

p2 metadata is attached to the project and would then be published along with the artifact

Actually, if the p2.inf is included in the artifact and is honored later by the PDE target resolution, and by Tycho target resolution and by p2-maven-site

p2.inf is only considered at build time but not later on, but p2-maven-site will contain it as it is a regular p2 site just deployed at maven repository instead of http/ftp/....

mickaelistria · 2023-11-28T09:02:58Z

p2.inf is only considered at build time but not later on

IIRC, if the p2.inf is embedded at the right place in the artifact, the p2 publisher would always process it. So if client use the publisher, sharing the p2.inf is enough as every client should then regenerate the same p2 metadata.
But anyway, whatever works: if p2 metadata are published for this Maven artifacts directly (instead of assuming clients will regenerate them properly), that's good too.

laeubi · 2023-11-28T09:20:09Z

IIRC, if the p2.inf is embedded at the right place in the artifact, the p2 publisher would always process it. So if client use the publisher, sharing the p2.inf is enough as every client should then regenerate the same p2 metadata.

That's possible at least Tycho do not do any special processing if used as maven artifact in a target everything is delegated to P2 publisher. But p2.inf is not the only source in a Tycho build for p2 metadata.

But anyway, whatever works: if p2 metadata are published for this Maven artifacts directly (instead of assuming clients will regenerate them properly), that's good too.

This is one thing we should/can check then as well if Tycho also would download such data and use it later on.

vogella · 2023-12-20T09:16:27Z

Maybe we could we also directly publish to repo.eclipse.org?

laeubi force-pushed the deploy_to_maven branch from e20b1de to 0f5bcf2 Compare November 27, 2023 08:00

laeubi force-pushed the deploy_to_maven branch 5 times, most recently from b216b17 to d34b33e Compare November 27, 2023 09:03

laeubi force-pushed the deploy_to_maven branch from d34b33e to b37b3c9 Compare November 27, 2023 10:15

laeubi force-pushed the deploy_to_maven branch from b37b3c9 to fe9b814 Compare November 27, 2023 11:09

HannesWell reviewed Nov 27, 2023

View reviewed changes

Deploy PDE artifacts to maven

0ddb87f

laeubi force-pushed the deploy_to_maven branch from fe9b814 to 0ddb87f Compare November 28, 2023 08:47

laeubi mentioned this pull request Dec 5, 2023

Create a p2 repo with PDE content #826

Merged

vogella mentioned this pull request Dec 20, 2023

Publish Eclipse features also to Maven central eclipse-platform/eclipse.platform.releng.aggregator#1421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy PDE artifacts to maven #936

Deploy PDE artifacts to maven #936

laeubi commented Nov 27, 2023

akurtakov commented Nov 27, 2023 •

edited

Loading

laeubi commented Nov 27, 2023

akurtakov commented Nov 27, 2023

laeubi commented Nov 27, 2023

github-actions bot commented Nov 27, 2023 •

edited

Loading

laeubi commented Nov 27, 2023

vogella commented Nov 27, 2023

laeubi commented Nov 27, 2023

akurtakov commented Nov 27, 2023

HannesWell left a comment

HannesWell Nov 27, 2023

HannesWell Nov 27, 2023

HannesWell Nov 27, 2023

mickaelistria commented Nov 28, 2023

mickaelistria commented Nov 28, 2023

laeubi commented Nov 28, 2023

mickaelistria commented Nov 28, 2023

laeubi commented Nov 28, 2023

vogella commented Dec 20, 2023

	mvn clean ${MVN_GOALS} --batch-mode -Dmaven.repo.local=$WORKSPACE/.m2/repository \
	mvn clean ${getMavenGoals()} --batch-mode -Dmaven.repo.local=$WORKSPACE/.m2/repository \

Deploy PDE artifacts to maven #936

Are you sure you want to change the base?

Deploy PDE artifacts to maven #936

Conversation

laeubi commented Nov 27, 2023

akurtakov commented Nov 27, 2023 • edited Loading

laeubi commented Nov 27, 2023

akurtakov commented Nov 27, 2023

laeubi commented Nov 27, 2023

github-actions bot commented Nov 27, 2023 • edited Loading

Test Results

laeubi commented Nov 27, 2023

vogella commented Nov 27, 2023

laeubi commented Nov 27, 2023

akurtakov commented Nov 27, 2023

HannesWell left a comment

Choose a reason for hiding this comment

HannesWell Nov 27, 2023

Choose a reason for hiding this comment

HannesWell Nov 27, 2023

Choose a reason for hiding this comment

HannesWell Nov 27, 2023

Choose a reason for hiding this comment

mickaelistria commented Nov 28, 2023

mickaelistria commented Nov 28, 2023

laeubi commented Nov 28, 2023

mickaelistria commented Nov 28, 2023

laeubi commented Nov 28, 2023

vogella commented Dec 20, 2023

akurtakov commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Nov 27, 2023 •

edited

Loading