Version compatibility bits (remove old compat code, bump requirement to 3.7+) #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I'm dropping support for Python 2 which cause trouble and Python 2 is EOL for long time. For that reason the next release I'll do is a 2.0 so we could do some breaking changes. Dropping support for Python 3.5 and 3.6 seems a good idea. I've kept 3.7 because is was EOL only few months ago. |
|
BTW: could you add a Signed-Off to your commit ? This is a requirement from Eclipse to acknowledge you agree with the ECA. |
akx
force-pushed
the
version-compat-bits
branch
from
74d7c7e
to
c1512f9
Compare
|
@PierreF Added signoffs and bumped the references to 3.6 to 3.7. |
akx
changed the title
PierreF
reviewed
Dec 20, 2023
akx
force-pushed
the
version-compat-bits
branch
from
c1512f9
to
dfbeb19
Compare
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
akx
force-pushed
the
version-compat-bits
branch
from
dfbeb19
to
c92af97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #757 and 0bc4d41, it's clear that this library is not meant to support Pythons older than 3.7, so:
requires_pythonstanza tosetup.pyto mark this as compatible with Python 3.7+.