Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTTPacket test refactor #249

Merged
merged 2 commits into from
Aug 24, 2023
Merged

MQTTPacket test refactor #249

merged 2 commits into from
Aug 24, 2023

Conversation

CIPop
Copy link

@CIPop CIPop commented Aug 17, 2023

This is work continuation over #248. To review only new changes, see only the latest commit.

  • Extracting the test harness within a separate include file.
  • Extracting the MQTTV3Packet test (newly added in Side-by-side MQTTPacket and MQTTV5Packet #248) and existing V5 test in include files
  • Code stitching to create 3 separate tests:
    • MQTTv3 Packet lib
    • MQTTv5 Packet lib
    • MQTTv3 Packet lib and MQTTv5 Packet lib side-by-side

@CIPop CIPop force-pushed the test_simplification branch 3 times, most recently from c13456a to b92042e Compare August 22, 2023 23:05
This was referenced Aug 22, 2023
Merged
Merged
@icraggs icraggs merged commit a8f0eb5 into eclipse-paho:mqttv5 Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CIPop @icraggs