Fix P allocationInlining OffHeap len cmp to use cmp4 instead of cmp8 #21184
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity aix,plinux jdk8,jdk23 |
|
please follow up with a performance enhancing PR (fix the sub-optimal code seq). |
|
Passed tests, good for merge |
|
failed test: cmdLineTester_criu_jitserverPostRestore_2 |
|
given above, merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array allocation length is a int node/value, using a cmp8 on it can result in the wrong result if it the register has undefined value in the upper 4-bytes.
Current code show proper cmp instruction compared to the added offheap check.
WIP: finishing tests