Fix compile error introduced in #21153

[keithc-ca]

Compilers on platforms that don't use GCC (e.g. Windows) were failing.

[amicic]

while there you can use your macro at line 118 and 132, and remove the declarations of those methods, so the solution is consistent

[amicic]

@TobiAjila you did not have a problem with unused j9javaArray_BA ?

edit: I guess, it is used by j9javaArray_##elemType##_EA (although effectively either both are used or unused)

[keithc-ca]

use your macro at line 118 and 132, and remove the declarations of those methods, so the solution is consistent

Good idea. I'll update the change accordingly.

[keithc-ca]

Updated. The declarations needed to stay because GCC complains if __attribute__ ((__unused__)) is applied to a function definition.

[amicic]

Updated. The declarations needed to stay because GCC complains if __attribute__ ((__unused__)) is applied to a function definition.

but it is successfully applied at the definition of j9javaArray_##elemType##_EA

[keithc-ca]

In draft mode until IBM Java 8 builds work also.

[keithc-ca]

#21153 has been reverted; I'll see if I can rework this to achieve the goal of that change while keeping all compilers happy.