Add inline iTable walk for Checkcast on Z #21134
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds superclass check checks for class depth at compile time to skip over superclass test for the case when toClassDepth > fromClassDepth Signed-off-by: Matthew Hall <[email protected]>
When the cast class is known to be an interface at compile time, only the interface test is generated. When this is not known, the superclass test will check the modifier flags and branch to the interface test accordingly. Signed-off-by: Matthew Hall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an iTable walk inline for
checkcastnodes on Z instead of calling out to the helpersupportsCheckcastInlineItableWalk()method toJ9CodeGeneratorInterfaceTestto thecheckcastgenerated sequences when thetoClassis known to be an interface at compile timeisCheckcast()andsupportsCheckcastInlineItableWalk()