Find and consume all -X / -XX options relevant to the JIT #21126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpirvu what do you think of this proposal? If it seems ok to you, I can clean it up a bit (add doxygen comments, better commit messages) and remove the WIP. |
mpirvu
approved these changes
Feb 14, 2025
dsouzai
force-pushed
the
externalOptions
branch
from
a3802b2 to
032a216
Compare
|
@mpirvu good for review now. |
mpirvu
reviewed
Feb 14, 2025
This commit adds the ExternalOptionsMetadata struct as well as a table of this struct to contain information about External Options that the JIT processes. This commit also adds a method to find and possibly consume the options, caching the arg index. Finally, this commit adds some documentation to describe how to add a new external option. Signed-off-by: Irwin D'Souza <[email protected]>
This commit updates the JIT to use the External Options Metadata table. This ensures that all external options that are used to control JIT functionality are consumed, which prevents the JVM from terminating early with an error when -XX:-IgnoreUnrecognizedXXColonOptions is specified. Signed-off-by: Irwin D'Souza <[email protected]>
dsouzai
force-pushed
the
externalOptions
branch
from
032a216 to
4f0a527
Compare
mpirvu
approved these changes
Feb 14, 2025
|
jenkins test sanity all jdk17 |
|
There are many failures in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #21122.
The proposed change iterates over all
J9::ExternalOptionsand callsFIND_AND_CONSUME_VMARGon the ones that are consumed by the JIT, caching the arg index. This ensures that-XX:-IgnoreUnrecognizedXXColonOptionsdoes not cause the JVM to terminate incorrectly.Aside from the root cause of #21122, there were several options that were only processed using
FIND_ARG_IN_VMARGS, which would also run into the-XX:-IgnoreUnrecognizedXXColonOptionsissue; this means that simply movingcheckArgsConsumedas I suggested in #21122 isn't a complete solution.Closes #21122