x86: Implement String.hashCode with vectorizedHashCode() #21119
Conversation
Signed-off-by: Bradley Wood <[email protected]>
|
@vijaysun-omr Would you mind reviewing? |
|
Looks fine to me, but I'll also get @0xdaryl to look since this is x86 codegen |
|
Seems like a good change to me. |
|
If/when the WIP is taken off this PR, one of Daryl or I can start testing, thanks. |
|
@vijaysun-omr @0xdaryl I have undrafted this PR. The fix for #21000 was merged in OMR (not promoted yet) |
|
jenkins test sanity all JDK21 |
|
@vijaysun-omr I am seeing erroneous NullPointerExceptions and NoClassDefFoundError, I couldn't find any know issue for the way these are produced. I think a string hashCode() problem could easily cause these kinds of issues. I also noticed that since OMR hadn't promoted at the time you launch the build (it has now), the fix for #21000 was not in the build. I would suggest relaunching the build now that OMR has promoted, and if the same issues reproduce, a further investigation is warranted. |
|
jenkins test sanity all JDK21 |
|
@vijaysun-omr Build looks good to me. I count 1 CRIU issue, 2 infrastructure issues, and 1 other known issue. Infrastructure - sha checksum error |
Leaving as draft until #21000 is resolved.