Z: Accelerate inlining Thread.onSpinWait() #20714
Open
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accelerate inlining Thread.onSpinWait() on z. Thread.onSpinWait() is a simple `nop` instruction on z. Enabled by default. Disable by setting the `TR_noPauseOnSpinWait` environment variable. Signed-off-by: Ehsan Kiani Far <[email protected]>
ehsankianifar
commented
Nov 29, 2024
| TR::Instruction* cursor = new (cg->trHeapMemory()) TR::S390NOPInstruction(TR::InstOpCode::NOP, 2, node, cg); | ||
|
|
||
| TR::Compilation *comp = cg->comp(); | ||
| static const bool printIt = feGetEnv("TR_showPauseOnSpinWait") != NULL; |
There was a problem hiding this comment.
TR_showPauseOnSpinWait would be a little misleading since "PAUSE" instruction is x86 specific but I have to use the same env variable because it was used in shared code and x86!
|
@r30shah I renamed the branch and it caused the older PR to close. I opened this one with a different branch name. Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread.onSpinWait() is a simple
nopinstruction on z. Enabled by default. Disable by setting theTR_noPauseOnSpinWaitenvironment variable.