Revert "Merge pull request #20525" #20701
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xdaryl May I ask you to review this change? The latest discussion is in the internal issue 482. Thank you! |
|
A reminder that if we want this reverted in the 25_01 release it will need to be double delivered both to 0.49 and the IBM 25_01 branch. |
|
We're just waiting on some additional performance runs (hopefully completed today) before deciding how to proceed with this. |
|
Presumably, an OMR breaking change to revert as the original change was. Depends on eclipse-omr/omr#7568. |
|
Jenkins test sanity xlinux jdk21 depends eclipse-omr/omr#7568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit edccce1, reversing changes made to ec1ae09.
This reverts PR #20525 and reduces the threshold for reference arraycopy REP MOVS instructions back to 32 bytes
This addresses the performance regression reported in the internal issue 482.