Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPKnownObject Constraints for JITServer #20695

Merged
merged 1 commit into from
Dec 2, 2024
Merged

VPKnownObject Constraints for JITServer #20695

merged 1 commit into from
Dec 2, 2024
+115 −1

Conversation

luke-li-2003
Copy link
Contributor

Ensure VPKnownObject works in server mode with appropriate queries.

@luke-li-2003
Copy link
Contributor Author

@mpirvu

mpirvu
mpirvu reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments inline. Also, please update JITServer version

runtime/compiler/env/VMJ9.h Show resolved Hide resolved
runtime/compiler/control/JITClientCompilationThread.cpp Outdated Show resolved Hide resolved
runtime/compiler/env/VMJ9.cpp Outdated Show resolved Hide resolved
@mpirvu mpirvu self-assigned this Nov 28, 2024
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Nov 28, 2024
@mpirvu mpirvu mentioned this pull request Nov 28, 2024
Open
@luke-li-2003 luke-li-2003 force-pushed the ServerVPKnownObject branch 3 times, most recently from b270904 to 31ed188 Compare November 28, 2024 16:56
mpirvu
mpirvu reviewed Nov 28, 2024
View reviewed changes
runtime/compiler/env/VMJ9Server.cpp Outdated Show resolved Hide resolved
runtime/compiler/env/VMJ9Server.cpp Show resolved Hide resolved
@luke-li-2003 luke-li-2003 force-pushed the ServerVPKnownObject branch 2 times, most recently from cdf9f73 to 19a30b0 Compare November 28, 2024 19:58
@mpirvu
Copy link
Contributor

mpirvu commented Nov 28, 2024

jenkins compile all jdk8,jdk23

@mpirvu mpirvu marked this pull request as ready for review November 28, 2024 20:02
@mpirvu mpirvu requested a review from dsouzai as a code owner November 28, 2024 20:02
@mpirvu
Copy link
Contributor

mpirvu commented Nov 28, 2024

This branch has conflicts that must be resolved

@luke-li-2003 please rebase and resolve the conflicts

@luke-li-2003
VPKnownObject Constraints for JITServer
c798230 
Ensure VPKnownObject works in server mode with appropriate queries.

Signed-off-by: Luke Li <[email protected]>
@mpirvu
Copy link
Contributor

mpirvu commented Nov 29, 2024

jenkins test sanity xlinux,xlinuxjit jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 2, 2024

openjdk tests have failed the VectorAPI tests with jitserver enabled which is a known failure.
This PR is ready to be merged.

@mpirvu mpirvu merged commit 735ab88 into eclipse-openj9:master Dec 2, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees

@mpirvu mpirvu

Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
JIT as a Service
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-li-2003 @mpirvu