WIP: Print actual string arguments with -Xtrace (part 2) #20662
+62
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3110n3rv3
changed the title
|
@TobiAjila could you please review for comments/concerns/feedback? Thanks |
h3110n3rv3
changed the title
h3110n3rv3
changed the title
h3110n3rv3
changed the title
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
2 times, most recently
from
1095ae8
to
8606fa4
Compare
The changes reflect the feature request eclipse-openj9#16416. Adding cmdline option to specify string argument length. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If methodStrArgLen = 0 or unspecified, default to 32. Other invalid inputs result in the input error. There will be subsequent PR for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
force-pushed
the
Feature-request-16416-part2
branch
from
6f968b4
to
2a77535
Compare
The changes reflect the feature request eclipse-openj9#16416. Adding cmdline option to specify string argument length. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If methodStrArgLen = 0 or unspecified, default to 32. Other invalid inputs result in the input error. There will be subsequent PR for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>
The changes reflect the feature request eclipse-openj9#16416. Adding cmdline option to specify string argument length. -Xtrace:methodstrarglen=[1-128] methodStrArgLen takes an unsigned integer value from 1 to 128 If methodStrArgLen = 0 or unspecified, default to 32. Other invalid inputs result in the input error. There will be subsequent PR for tests (part 3). Signed-off-by: Nick Kamal <[email protected]>
tajila
reviewed
Nov 28, 2024
if argument == 0 default to address printing
tajila
reviewed
Nov 28, 2024
tajila
reviewed
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes reflect the feature request #16416.
Adding cmdline option to specify string argument length.
-Xtrace:methodstrarglen=[1-128]
methodStrArgLen takes an unsigned integer value from 1 to 128
If methodStrArgLen = 0 or unspecified, default to address printing.
Other invalid inputs result in the input error.
There will be subsequent PR for tests (part 3).
Signed-off-by: Nick Kamal <[email protected]>