Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X: Remove popcnt specialization #20653

Merged
merged 1 commit into from
Nov 29, 2024
Merged

X: Remove popcnt specialization #20653

merged 1 commit into from
Nov 29, 2024
+1 −60

Conversation

Spencer-Comin
Copy link
Contributor

With ipopcnt and lpopcnt IL opcodes implemented in OMR, the OpenJ9 specializations are no longer needed.

Depends on eclipse-omr/omr#7553

@Spencer-Comin Spencer-Comin marked this pull request as ready for review November 25, 2024 16:03
hzongaro
hzongaro reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

runtime/compiler/x/codegen/J9TreeEvaluator.hpp Show resolved Hide resolved
@hzongaro hzongaro self-assigned this Nov 26, 2024
@Spencer-Comin
X: Remove popcnt specialization
37a43ae 
With ipopcnt and lpopcnt IL opcodes implemented in OMR, the OpenJ9
specializations are no longer needed.

Singed-off-by: Spencer Comin <[email protected]>
hzongaro
hzongaro approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

As this only affects x86, I shouldn't have run testing on all platforms - I'll ignore any problems on non-x86. Windows builds are out of commission at the moment, so I'll have to ignore those as well. Rerunning any other failing x86 builds.

Jenkins test sanity.functional xmac jdk11,jdk17 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk xmac jdk8 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

Failure in JDK 8 xlinux sanity.functional testing appears to be due to known issue #18599

@hzongaro
Copy link
Member

It looks like the JDK 8 x86 macOS sanity.openjdk test run timed out. Rerunning. . . .

Jenkins test sanity.openjdk xmac jdk8 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

The only x86-specific failures were for known reasons. All other x86 testing was successful. Merging.

@hzongaro hzongaro merged commit 19118bd into eclipse-openj9:master Nov 29, 2024
75 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

Assignees

@hzongaro hzongaro

Labels
arch:x86 comp:jit depends:omr:breaking tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spencer-Comin @hzongaro