Reset queued methods on cache flush #20628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running under FSD, class redefinition results in all methods being unloaded from the class cache and the compilation queues are emptied. This is partly accomplished by jitResetAllMethods in decomp.cpp, however it misses those methods that have been queued but not yet compiled. The result is that after class redef a subset of methods will never be recompiled, with a potentially significant impact on performance. This change ensures that queued methods also have their status reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under FSD, class redefinition results in all methods being unloaded from the class cache and the compilation queues are emptied. This is partly accomplished by jitResetAllMethods in decomp.cpp, however it misses those methods that have been queued but not yet compiled. The result is that after class redef a subset of methods will never be recompiled, with a potentially significant impact on performance. This change ensures that queued methods also have their status reset.