Add JFR CPULoad and ThreadCPU event support #20186
Open
+326
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila requesting your review |
|
Im seeing negative numbers for Thread user mode CPU load |
tajila
reviewed
Oct 4, 2024
tajila
reviewed
Oct 4, 2024
tajila
reviewed
Oct 4, 2024
tajila
reviewed
Oct 4, 2024
tajila
reviewed
Oct 4, 2024
tajila
reviewed
Oct 4, 2024
thallium
force-pushed
the
cpuload
branch
2 times, most recently
from
9399d91
to
9f17f2e
Compare
tajila
reviewed
Oct 7, 2024
thallium
force-pushed
the
cpuload
branch
3 times, most recently
from
42e1d9d
to
94218be
Compare
tajila
reviewed
Oct 10, 2024
tajila
reviewed
Oct 10, 2024
tajila
reviewed
Oct 10, 2024
tajila
reviewed
Oct 10, 2024
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 10, 2024
This function returns the user and system cpu time of the calling thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
|
Opend OMR PR and addressed previous state. |
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 10, 2024
This function returns the user and system cpu time of the calling thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
keithc-ca
requested changes
Oct 11, 2024
runtime/vm/jfr.cpp
Outdated
Comment on lines
848
to
851
| if (count % 100 == 0) { // 1000ms | ||
| jfrCPULoad(currentThread); | ||
| } | ||
| if (count % 1000 == 0) { // 10s |
There was a problem hiding this comment.
Missing parentheses, constants go on the left of ==:
if (0 == (count % 100)) { // 1000msBy the way, how do you conclude that 100 counts is 1000ms?
There was a problem hiding this comment.
J9JFR_SAMPLING_RATE is defined to be 10 so 100 counts is 1000ms
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed because the only way that we're aware of to get the user CPU time of a thread is to use getrusage(RUSAGE_THREAD, ...) which can only be called on the current thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed because the only way that we're aware of to get the user CPU time of a thread is to use getrusage(RUSAGE_THREAD, ...) which can only be called on the current thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed because the only way that we're aware of to get the user CPU time of a thread is to use getrusage(RUSAGE_THREAD, ...) which can only be called on the current thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed because the only way that we're aware of to get the user CPU time of a thread is to use getrusage(RUSAGE_THREAD, ...) which can only be called on the current thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
keithc-ca
reviewed
Oct 11, 2024
keithc-ca
reviewed
Oct 11, 2024
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 11, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed because the only way that we're aware of to get the user CPU time of a thread is to use getrusage(RUSAGE_THREAD, ...) which can only be called on the current thread. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
keithc-ca
requested changes
Oct 11, 2024
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 18, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed so we can get both user time and system time using only one system call. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 21, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed so we can get both user time and system time using only one system call. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Oct 22, 2024
This function returns the user and system cpu time of the calling thread. This new function is needed so we can get both user time and system time using only one system call. Related: eclipse-openj9/openj9#20186 Signed-off-by: Gengchen Tuo <[email protected]>
|
Addressed previous feedbacks |
|
@thallium Please rebase your changes |
Depends on: eclipse-omr/omr#7491 Signed-off-by: Gengchen Tuo <[email protected]>
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: eclipse-omr/omr#7491