Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jextract/jpackcore not packaged in Java 8 JDK for Windows #20661

Closed
JamesKingdon opened this issue Nov 21, 2024 · 12 comments · Fixed by ibmruntimes/openj9-openjdk-jdk8#785
Closed

Comments

@JamesKingdon
Copy link
Contributor

A customer reported not being able to find jextract in their Semeru Java 8 installation on Windows, so I downloaded the latest build of the jdk (ibm-semeru-open-jdk_x86-32_windows_8u432b06_openj9-0.48.0.zip) and confirmed that I couldn't find it either.

Copy link

Issue Number: 20661
Status: Open
Recommended Components: comp:build, comp:vm, comp:jclextensions

@pshipton
Copy link
Member

This might be intentional, since you don't need to run jpackcore on Windows. I find it in the jre/bin directory for other platforms.

@pshipton
Copy link
Member

The doc indicates AIX, Linux, macOS.
https://eclipse.dev/openj9/docs/tool_jextract/#dump-extractor-jpackcore

@pshipton
Copy link
Member

We are excluding Windows on jdk8.
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/openj9/jdk/make/CompileLaunchers.gmk#L524

I see in jdk11+ jextract/jpackcore are included.

@pshipton
Copy link
Member

We could include it, but it does bundle all the dlls on Windows, which afaik aren't needed since the data is included in the core file.
Any particular reason the customer was looking for it on Windows?

@keithc-ca keithc-ca self-assigned this Nov 21, 2024
@keithc-ca
Copy link
Contributor

It's not present on Linux either (I checked 0.46.0).

@pshipton
Copy link
Member

I see it in xlinux 0.46. It's in jre/bin and not bin.

@keithc-ca
Copy link
Contributor

You're right (I didn't look there). Shouldn't it be in both places (in a JDK)?

@pshipton
Copy link
Member

Shouldn't it be in both places (in a JDK)?

It wouldn't hurt but nobody is complaining about that afaik.

@JamesKingdon
Copy link
Contributor Author

We could include it, but it does bundle all the dlls on Windows, which afaik aren't needed since the data is included in the core file. Any particular reason the customer was looking for it on Windows?

I think because we are used to asking for system cores to be processed with jextract by default. I noticed that the docs for jextract don't mention Windows. I don't know for sure if we get everything we need without using jextract or not - it would be amusing if we've been asking for it for years without needing it.

@keithc-ca
Copy link
Contributor

For the record, those tools were explicitly omitted via ibmruntimes/openj9-openjdk-jdk8#205.

Copy link

Issue Number: 20661
Status: Closed
Actual Components: comp:build, userRaised
Actual Assignees: No one :(
PR Assignees: keithc-ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants