Accelerate Unsafe CAS Intrinsics on Aarch64 #7505
Open
+9
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for acceleration of compareAndExchange[Int|Long|Reference] has been extended to Arm. As a result, the check in callDoesAnImplicitAsyncCheck needs to be updated as well. Cleans up isUnsafeCAS and isUnsafeWithObjectArg to remove unused comp parameter. Signed-off-by: jimmyk <[email protected]>
IBMJimmyk
requested review from
vijaysun-omr,
0xdaryl and
mstoodle
as code owners
|
@hzongaro When you get the chance, could you look over these common changes? |
hzongaro
requested review from
hzongaro
and removed request for
mstoodle,
0xdaryl and
vijaysun-omr
hzongaro
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for acceleration of
compareAndExchange[Int|Long|Reference]has been extended to Arm. As a result, the check incallDoesAnImplicitAsyncCheckneeds to be updated as well.Cleans up
isUnsafeCASandisUnsafeWithObjectArgto remove unused comp parameter.Needs to be check in with:
eclipse-openj9/openj9#20432
Due to the changes to the parameters of
isUnsafeCASandisUnsafeWithObjectArg.