Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable RegDepCopyRemoval for value types #7497

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r30shah
Copy link
Contributor

@r30shah r30shah commented Oct 22, 2024

As documented in eclipse-openj9/openj9#9712, initial attempt to fix the SplitPostGRA to work with RegDepCopyRemoval resulted in 5% regression in performance throughput on x86 which required us to disable the RegDepCopyRemoval when value types are enabled. Later on the performance issue was addressed and fixed. This PR reverts the change that disabled RegDepCopyRemoval when value types are enabled.

As documented in eclipse-openj9/openj9#9712,
initial attempt to fix the SplitPostGRA to work with RegDepCopyRemoval
resulted in 5% regression in performance throughput on x86 which
required us to disable the RegDepCopyRemoval when value types are
enabled. Later on the performance issue was addressed and fixed. This PR
reverts the change that disabled RegDepCopyRemoval when value types are
enabled.

Signed-off-by: Rahil Shah <[email protected]>
@r30shah
Copy link
Contributor Author

r30shah commented Oct 22, 2024

Validating performance and functionality with this change, marking it WIP till then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant