Issue #95 - Update NatTable to the latest dependencies

[fipro78]

Updated examples build, removed e4.rcp.feature, updated BREE to JavaSE-11, corrected deprecated warnings, updated version to 2.5.0

[fipro78]

@merks
I have done several modifications to align with your latest changes. While working on it, it reminded me on this

But well, I got it working now. The only issue that is still left, is that in the exported product, opening the RichTextEditor breaks. It looks like the ProgressListener is not called in the exported product. Interestingly it works fine when starting from within the Eclipse IDE.

@HannesWell
Do you have an idea what could be the problem with the Browser ProgressListener in an exported product on Windows 11?

[merks]

FYI, I am at the IDE WG's community event today and ad the IDE WG Steering Committee meeting, so am quite tied up...

[merks]

I wonder what the need for this is?

		  <dependencies>
			  <dependency>
				  <groupId>org.apache.logging.log4j</groupId>
				  <artifactId>log4j-to-slf4j</artifactId>
				  <version>2.23.1</version>
				  <type>jar</type>
			  </dependency>
		  </dependencies>

[fipro78]

This is the Log4j2 to slf4j bridge. Apache poi 5 uses Log4j2 for logging. To make it work with slf4j and the simple binding in the example app, you need to forward the Log4j2 calls to slf4j. Otherwise you only see an error when a poi logging is performed.

[merks]

Good to know. This might affect BIRT as well which also uses poi. I'll look at getting it into Orbit.

This is available as an OSGi bundle so that's easy to include in Orbit (and GPG sign it):

https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-to-slf4j/2.23.1/

[fipro78]

I think several slf4j bridges and bindings are missing in Orbit

[merks]

I think several slf4j bridges and bindings are missing in Orbit

It's not missing if no one has asked for it. 😛

In BIRT I only see this in the bundle where poi is used:

So their use case might be different, or there's a problem they haven't noticed...

[merks]

FYI, the unzipped Windows product is working for me with your PR:

[fipro78]

Apache POI introduced the internal usage of Log4j2 with 5.1.0

https://poi.apache.org/changes.html

Before it was commons logging IIRC. Maybe BIRT did not come across the issue yet.

You started to update the dependencies, so to really check what is working and what not, you need to check examples that use those dependencies.

For Apache POI:
Tutorial Examples - AdditionalFunctions - GridExcelExportFormatterExample

This example uses HSSF to create the Excel export. If you want to see the effect if log4j.to.slf4j is missing, remove it from the examples.e4.feature and trigger an export from the example. You should get an error on the console about a missing log4j2 binding.

The error I mentioned with the RichTextEditor can be triggered via:
Tutorial Examples - Configuration - NebulaRichTextEditorIntegrationExample

Click in a cell in the Description column to open the RichTextEditor. From within the IDE this works fine. But in the exported product the editor can not gain the focus to start typing. And on closing the editor via ESC we run into an endless "widget is disposed" error. The reason seems to be that the ProgressListener is not triggered, which performs the necessary initialization.

[merks]

It's super helpful that you are solving problems for me even before I have them. 👍 😁

[fipro78]

It's super helpful that you are solving problems for me even before I have them. 👍 😁

I can only repeat "One should not simply upgrade to the latest version" 😜

BTW, you need to be careful with the log4j2.to.slf4j bridge. If you use SLF4J to Log4j binding in the same runtime, you get a endless routing Log4j2 to SLF4j and back.

https://logging.apache.org/log4j/2.3.x/log4j-to-slf4j/

Just in case you see this. I am not aware of people in the Eclipse / OSGi world using Log4j2 as logging backend, but you need to be aware of it just in case.

Is it ok for you if I merge this PR now? As said, I still need to find a fix for the RichTextEditor. But with that change most of the stuff should be ready to go. Do you have some additional modifications in place?

And could you maybe add the Oomph setup description to the README? Not sure what and how to add to make it easier for contributors. But probably after I merged my stuff.

[merks]

Yes, merge it and then we can progress from this point. Indeed it's on my TODO list to add the Oomph setup details to the *.md. Note that the setup broken right now with your target platform change, but I'll get that fixed too. So let's merge and move forward anyway.

[fipro78]

@merks
I have merged it, so you we can proceed from here.