Fixes #118 - [Performance] Excel-like filter for huge data sets #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional optimizations related to collection checks Signed-off-by: Dirk Fauth <[email protected]>
|
I added modifications you suggested in #119 At least mostly. In ComboBoxFilterRowHeaderComposite line 922 I think I can't simply change to a HashMap, because the filter list that is managed internally needs to be changed. A local copy would break that case. And I am not sure about side effects if we change to a HashSet for filter value storage internally. That would be a bigger change, and I am not sure if this would be really beneficial. |
|
Looks all good for me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional optimizations related to collection checks