Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lyo build issues #98

Merged
merged 5 commits into from
Jun 5, 2021
Merged

Fix Lyo build issues #98

merged 5 commits into from
Jun 5, 2021

Conversation

berezovskyi
Copy link
Contributor

@berezovskyi berezovskyi commented May 6, 2021

Description

We have the following problems:

  • Kotlin classes from the TRS libs were not covered in the Javadoc; JDK11 fails the build (but more importantly, our users were getting incomplete javadoc JARs)
  • SHACLex library is no longer available from Bintray because it shut down
    - SHACLex 0.0.87 is not available in the new repo
    - SHACLex 0.1.x breaks the 0.0.8x API; updates needed (asked for help in Provide an example of how to use inside Java weso/srdf#168)

TODOs

  • Update the build to add GH repo credentials to secrets?
  • Fix the SHACLex invocation (we should consider building a Scala shim that would be easy to invoke from Java and would not use any advanced Scala features on the outside API)
  • Remove use of Bintray by Dokka plugin

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API

Issues

Closes #78; see #80

@berezovskyi berezovskyi changed the title Fix TRS build issues Fix Lyo build issues May 6, 2021
@berezovskyi
Copy link
Contributor Author

Tracking Lyo Validation package retrieval issue in https://bugs.eclipse.org/bugs/show_bug.cgi?id=574043.

@berezovskyi berezovskyi marked this pull request as ready for review June 5, 2021 22:41
@berezovskyi berezovskyi force-pushed the b-fix-broken-build branch from cbb3a81 to dd22b9a Compare June 5, 2021 22:51
berezovskyi and others added 5 commits June 6, 2021 00:56
- Add a unit test to check that ChangeLog events are serialised to RDF
- Clean up JCenter references
- Add build timeout
- Clean up inherited properties
- Removed HTTP-only repositories due to https://maven.apache.org/docs/3.8.1/release-notes.html#how-to-fix-when-i-get-a-http-repository-blocked
- Update Kotlin version to 1.5
@berezovskyi berezovskyi force-pushed the b-fix-broken-build branch from dd22b9a to fd17ceb Compare June 5, 2021 22:56
@berezovskyi berezovskyi merged commit a2ee872 into master Jun 5, 2021
@berezovskyi berezovskyi deleted the b-fix-broken-build branch June 5, 2021 22:58
@berezovskyi berezovskyi added this to the 4.1 milestone Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bintray shutting down; need to check our POMs
1 participant