Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive on regex flag validation #1631

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix false positive on regex flag validation #1631

merged 2 commits into from
Aug 23, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 14, 2024

Just a minor fix for a warning that would incorrectly appear when mix & matching non-regex terminal elements with regex terminal elements.

@msujew msujew added validation Validation related issue grammar Grammar language related issue labels Aug 14, 2024
@msujew msujew added this to the v3.2.0 milestone Aug 22, 2024
dhuebner
dhuebner approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!
Please consider to add the suggested additional test case.

packages/langium/test/grammar/grammar-validator.test.ts Show resolved Hide resolved
@msujew msujew merged commit 5507987 into main Aug 23, 2024
5 checks passed
@msujew msujew deleted the msujew/fix-regex-flag-validation branch August 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuebner dhuebner dhuebner approved these changes

Assignees
No one assigned
Labels
grammar Grammar language related issue validation Validation related issue
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msujew @dhuebner