Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent testing failure #1498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msujew
Copy link
Member

@msujew msujew commented May 15, 2024

In some of our CI runs (see here), the workspace lock test fails due to minor timing issues in the runtime. This change makes the test a bit more lenient regarding minor inaccuracies in the setTimeout mechanism.

@msujew msujew added polish Some feature needs improvement test Related to framework testing labels May 15, 2024
@JohannesMeierSE
Copy link
Contributor

While working on something else, I just faced this issue, where I got the "magical number 9":

Screenshot 2024-05-16 at 09 47 09

Therefore, approved from my side 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Some feature needs improvement test Related to framework testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants