generator api ('joinToNode') supplements #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skip the `toGenerated` argument (conversion function)
msujew
reviewed
Oct 26, 2023
Comment on lines
106
to
107
| const prefixFunc = typeof prefix === 'function' ? prefix : undefined; | ||
| const suffixFunc = typeof suffix === 'function' ? suffix : undefined; |
There was a problem hiding this comment.
Suggestion: All the undefined-checking and casting to Generated below is a bit ugly, we can just define the function here a bit smarter.
Suggested change
| const prefixFunc = typeof prefix === 'function' ? prefix : undefined; | |
| const suffixFunc = typeof suffix === 'function' ? suffix : undefined; | |
| const prefixFunc = typeof prefix === 'function' ? prefix : (() => prefix); | |
| const suffixFunc = typeof suffix === 'function' ? suffix : (() => suffix); |
sailingKieler
force-pushed
the
cs-generator-api-supplement
branch
2 times, most recently
from
9e14108 to
af9c170
Compare
… executions of 'joinToNode' * now allows specification of item prefixes and suffixes as fixed values, not only via provider functions * now allows demanding to not append a newline after the last item of the given iterable, provided 'appendNewLineIfNotEmpty' is set
sailingKieler
force-pushed
the
cs-generator-api-supplement
branch
from
af9c170 to
dcb55f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements inspired by applications in productive projects
joinToNodeallowing to skip thetoGeneratedargument (conversion function)