Recipe: Dependency loop detection #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
There was a problem hiding this comment.
Thank you very much for this recipe @Lotes!
It makes a lot of sense to have this recipe and I like the nice application for the hello-world example!
However, the first section with the motivation is not clear enough from my point of view. After reading the first sentences, it is not very clear, what the actual problem is.
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
Thanks @Lotes for the improvements! The two use cases are much more clear in the introduction now and I like the explicit examples. "approved" from my side 🙂 |
msujew
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a recipe for detecting any kind of dependency loop and resolving acyclic dependencies.
It is not specific to Langium, but it is one of these problems, that might need to be solved for several language features. Like recursion detection or recursive data structures.
The detection is implemented as a Langium validation. I think this is useful for users, that have never came across with such graph algorithms.