-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for unix domain sockets #94
Conversation
174f5ec
to
095f2fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 59.65% 59.35% -0.30%
==========================================
Files 33 33
Lines 15964 16048 +84
==========================================
+ Hits 9523 9525 +2
- Misses 6441 6523 +82 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
095f2fa
to
872e44f
Compare
I think we should add some documentation. Some things I think could be useful to include/mention:
When merged we should preferably also mention something on how to test it in https://github.com/eclipse-kuksa/kuksa-databroker/wiki/Release-Testing - I think we at least shall have some form of smoke test, manual or in Github CI to verify that it works before releasing. |
@@ -138,23 +131,55 @@ where | |||
.await | |||
} | |||
|
|||
pub async fn serve_with_incoming_shutdown<F>( | |||
listener: TcpListener, | |||
pub async fn serve_uds<F>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to get rid of uds
everywhere, i.e. rename this one to serve_unix_domain_socket
or similar?
ffa937e
to
f8d4388
Compare
Rebased the PR and added some basic documentation. Also addressed two of the comments |
d306024
to
c86b156
Compare
c86b156
to
6ecc025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.