Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unix domain sockets #94

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Nov 5, 2024

No description provided.

@argerus argerus force-pushed the feature/uds_support branch from 174f5ec to 095f2fa Compare November 5, 2024 13:48
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 17.17172% with 82 lines in your changes missing coverage. Please review.

Project coverage is 59.35%. Comparing base (9359eff) to head (6ecc025).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/main.rs 0.00% 58 Missing ⚠️
databroker/src/grpc/server.rs 41.46% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   59.65%   59.35%   -0.30%     
==========================================
  Files          33       33              
  Lines       15964    16048      +84     
==========================================
+ Hits         9523     9525       +2     
- Misses       6441     6523      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@argerus argerus force-pushed the feature/uds_support branch from 095f2fa to 872e44f Compare November 6, 2024 07:35
@erikbosch
Copy link
Contributor

I think we should add some documentation. Some things I think could be useful to include/mention:

  • Does the CLI support it?
  • Provide a example where we use the new argument. Preferably also with a client (if supported)
  • Mention that the socket is not protected by TLS or similar, that you may need to consider to mechanisms like MAC/DAC for protecting the socket
  • Mention that token functionality works the same way as for TCP/IP connection.

When merged we should preferably also mention something on how to test it in https://github.com/eclipse-kuksa/kuksa-databroker/wiki/Release-Testing - I think we at least shall have some form of smoke test, manual or in Github CI to verify that it works before releasing.

databroker/src/main.rs Outdated Show resolved Hide resolved
@@ -138,23 +131,55 @@ where
.await
}

pub async fn serve_with_incoming_shutdown<F>(
listener: TcpListener,
pub async fn serve_uds<F>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to get rid of uds everywhere, i.e. rename this one to serve_unix_domain_socket or similar?

@erikbosch erikbosch force-pushed the feature/uds_support branch 2 times, most recently from ffa937e to f8d4388 Compare November 8, 2024 09:30
@erikbosch
Copy link
Contributor

Rebased the PR and added some basic documentation. Also addressed two of the comments

@argerus argerus force-pushed the feature/uds_support branch 2 times, most recently from d306024 to c86b156 Compare November 14, 2024 13:40
@argerus argerus force-pushed the feature/uds_support branch from c86b156 to 6ecc025 Compare November 20, 2024 07:48
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@argerus argerus merged commit 66b1c91 into eclipse-kuksa:main Nov 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants