Fix workflows #3
Conversation
erikbosch
force-pushed
the
main
branch
2 times, most recently
from
706ddb9
to
e94639b
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| @@ -77,6 +81,8 @@ jobs: | |||
| - name: Generate code coverage | |||
| run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info | |||
| - name: Upload coverage to Codecov | |||
| # To use v4 a token must be specifed by "token: ${{ secrets.CODECOV_TOKEN }}"" | |||
There was a problem hiding this comment.
We get a warning "Node.js 16 actions are deprecated. " if using v3 (but it works).
If using v4 (to resolve warning) it seems we need to create a token and upload.
Could possibly be done similar to how we do for other secrets at https://github.com/eclipse-kuksa/.eclipsefdn/blob/main/otterdog/eclipse-kuksa.jsonnet#L29
| @@ -0,0 +1,13 @@ | |||
| # See https://pre-commit.com for more information | |||
There was a problem hiding this comment.
We can discuss how useful it is to have pre-commit as we mainly have Rust files, but if we have it we need this file. It will at least check for trailing whitespaces in *.md, *.yaml and similar files. Cargo tools maybe anyway do similar tasks for Rust files?
If not we should remove the corresponding workflow.
Previously no docker containers were published
Previously no docker containers were published. Also quite some links were dead. Fixed by adding files where missing or removing references to KUKSA Server if that was easier.