Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/databroker api v2 #101

Merged
merged 58 commits into from
Nov 13, 2024
Merged

Feature/databroker api v2 #101

merged 58 commits into from
Nov 13, 2024

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Nov 13, 2024

No description provided.

rafaeling and others added 30 commits October 22, 2024 09:53
@rafaeling @erikbosch
Init Databroker API V2
3030133
@rafaeling @erikbosch
Added oneof to Datapoint and some changes
b306d1b
@rafaeling @erikbosch
Rename oneof Datapoint
4ead652
@rafaeling @erikbosch
Add oneof for Stream Provider response
33229c4
@rafaeling @erikbosch
Update provide stream response and add files to the build project
0599f7a
@rafaeling @erikbosch
Update ProvideStream and Actuate calls
b9d55fd
@rafaeling @erikbosch
Add Start/Stop Signal
bfbf9bf
@rafaeling @erikbosch
Remove Start/Stop Signal and add batch methods
45eb635
@rafaeling @erikbosch
Use correct numeration
db3e10a
@rafaeling @erikbosch
Clean up and rename messages
1f04b60
@rafaeling @erikbosch
Move ValueFailure to bottom
7665757
@argerus @erikbosch
Add proposed API
5d94ff8
@rafaeling @erikbosch
Updates after review session
e19cfa6
@rafaeling @erikbosch
format
7925eca
@rafaeling @erikbosch
pre commit
604644f
@rafaeling @erikbosch
Improve documentation
f59dbb3
@rafaeling @erikbosch
Avoid reusing messages among calls
8fbc180
@rafaeling @erikbosch
Add signal i32 id to metadata
d21e057
@rafaeling @erikbosch
Fix year comment
8d4ad4b
@rafaeling @erikbosch
Introduce subscribe i32 parameter due to performance reasons
7303581
@rafaeling @erikbosch
Correct parameter name
1a08ef5
@rafaeling @erikbosch
Kuksa val v2 skeleton
22dbea2
@rafaeling @erikbosch
Initial publish request values implementation for OpenProviderStream
09f1d33
@rafaeling @erikbosch
Initial implementation for ListMetadata
3686c3f
@rafaeling @erikbosch
Extend unit test
8d2c9fa
@lukasmittag @erikbosch
Subscribe & publish_value
32e74d4
@lukasmittag @erikbosch
Formatting & clippy findings
39005a8
@lukasmittag @erikbosch
Fix test for subscribe
c88892c
@lukasmittag @erikbosch
Formatting
a7385b8
@lukasmittag @erikbosch
Test for get_signal_id and HashMap:with_capacity adaption
f0e2979
rafaeling and others added 25 commits October 22, 2024 09:53
@rafaeling @erikbosch
Remove oneof and ValueFailure from Datapoint and some proto naming im…
5102cb9 
…provements (#72)

* Remove oneof from Datapoint
@lukasmittag @erikbosch
Move conversion of UpdatError
e0a926a
@rafaeling @erikbosch
Add value restriction metadata
2d1cca3
@erikbosch
Add GetValue and GetValues Support (#75)
2897171 
* Add GetValue and GetValues  Support
@wba2hi @argerus @erikbosch
Implement Provider Actuation
abaafc0 
Co-authored-by: John Argérus <[email protected]>
@erikbosch
Remove ListValues
7b47ed9
@rafaeling
Implement server info service method
c117be6
@rafaeling
SubscribeById implementation
a8df2f6
@rafaeling
Merge pull request #83 from boschglobal/feature/add_databroker_server…
d94497e 
…_info

Implement server info service method
@rafaeling
Merge pull request #81 from boschglobal/feature/subscribe_by_id_imple…
d0424e9 
…mentation

Subscribe by id Integer32 implementation
@erikbosch
Min/Max Support (#79)
50f2ba6 
* Min/Max Support
@rafaeling
Update incomplete information on errors
59265ab
@rafaeling
Merge pull request #87 from boschglobal/fix/doc_open_provider_stream
95e3041 
Update incomplete information on errors
@rafaeling
Add OutOfRange error validation
3368c07
@rafaeling
Merge pull request #88 from boschglobal/fix/actuate_and_batch_actuate…
3bacf45 
…_out_of_range

Fix actuate and batch actuate out of range error
@rafaeling @erikbosch
@BjoernAtBosch @lukasmittag
Initiate Comprehensive Kuksa Requirements Analysis for Enhanced Versi…
1bc3f86 
…on Development (#21)


* Initiate Kuksa requirements analysis

---------

Co-authored-by: Erik Jaegervall <[email protected]>
Co-authored-by: BjoernAtBosch <[email protected]>
Co-authored-by: Lukas Mittag <[email protected]>
Co-authored-by: lukasmittag <[email protected]>
@rafaeling
Implement validatation of actuator type on acutation and some more er…
62552a5 
…rors
@rafaeling
Merge pull request #90 from boschglobal/feature/missing_errors_and_ch…
54755f0 
…eck_correct_actuation

Validation of actuator type on actuate and batch_actuate and extend UpdateErrors
@rafaeling
Add reflection support for kuksa.val.v2
8483c51
@rafaeling
Merge pull request #89 from boschglobal/feature/api-v2-reflection
aa4444f 
Add reflection support for kuksa.val.v2
@rafaeling
Add missing min max restriction
e737ae0
@rafaeling
Merge pull request #93 from boschglobal/feature/missing_min_max_restr…
f9f7f6f 
…iction_for_sdv_databroker_v1

Add missing min max restriction for sdv.databroker.v1
@rafaeling
[kuksa.val.v2] Improve throughput by skipping ACKs
de2730e 
* Improve throughput by not replying with `PublishValuesResponse` on success.
@rafaeling
Remove recently added optional from proto3 files
07eaf88 
* Remove of `optional` fields recently added to `sdv.databroker.v1` and `kuksa.val.v2` as this is not supported in older versions of proto3.
@argerus
Merge branch 'feature/databroker-api-v2'
041729b
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.70243% with 737 lines in your changes missing coverage. Please review.

Project coverage is 59.71%. Comparing base (0af2e2e) to head (041729b).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/conversions.rs 26.52% 313 Missing ⚠️
databroker/src/broker.rs 85.24% 166 Missing ⚠️
...tabroker/src/grpc/sdv_databroker_v1/conversions.rs 1.23% 80 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/val.rs 35.77% 79 Missing ⚠️
databroker/src/types.rs 27.11% 43 Missing ⚠️
databroker/src/main.rs 0.00% 12 Missing ⚠️
databroker/src/vss.rs 52.00% 12 Missing ⚠️
databroker/src/grpc/server.rs 15.38% 11 Missing ⚠️
databroker/src/viss/v2/server.rs 0.00% 10 Missing ⚠️
databroker/src/permissions.rs 66.66% 5 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   49.95%   59.71%   +9.76%     
==========================================
  Files          31       33       +2     
  Lines       11792    15906    +4114     
==========================================
+ Hits         5891     9499    +3608     
- Misses       5901     6407     +506

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rafaeling
rafaeling approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rafaeling rafaeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it has been reviewed while kuksa.val.v2 development

@argerus argerus merged commit 5604aa9 into main Nov 13, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeling rafaeling rafaeling approved these changes

@erikbosch erikbosch Awaiting requested review from erikbosch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@argerus @rafaeling @lukasmittag @erikbosch @wba2hi