[batch compiler] Unrecognized option : --patch-module #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
detect some errors + promote module not found to regular compile error
+ remove project info when removing module-info
integrate with multi-module compilation mode - evaluate patchModules before handleModuleSourcepath() which expects all module names to be known - write patching classfiles to the output location of their module
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
+ implement parsing of the --patch-module option + associate affected CUs to the given module + detect errors: syntax, duplicates, unresolved module + add entry to the -help command line help Required regression fix : + remove project info when removing module-info (JavaModel) fixes eclipse-jdt#1895
gayanper
pushed a commit
to gayanper/eclipse.jdt.core
that referenced
this pull request
Sep 7, 2024
+ implement parsing of the --patch-module option + associate affected CUs to the given module + detect errors: syntax, duplicates, unresolved module + add entry to the -help command line help Required regression fix : + remove project info when removing module-info (JavaModel) fixes eclipse-jdt#1895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1895