Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[batch compiler] Unrecognized option : --patch-module #1895

Closed
laeubi opened this issue Jan 22, 2024 · 2 comments · Fixed by #2544
Closed

[batch compiler] Unrecognized option : --patch-module #1895

laeubi opened this issue Jan 22, 2024 · 2 comments · Fixed by #2544
Assignees
@stephan-herrmann
Milestone
4.33 M1

Comments

@laeubi
Copy link
Contributor

laeubi commented Jan 22, 2024 •
edited
Loading

When passing the batch compiler the option --patch-module it fails with

Unrecognized option : --patch-module

See

FYI @stephan-herrmann
@laeubi laeubi mentioned this issue Jan 22, 2024
Open
@laeubi
Copy link
Contributor Author

laeubi commented Feb 12, 2024

Any chance this gets implemented so we did not miss another release?

@stephan-herrmann stephan-herrmann added this to the 4.32 M1 milestone Feb 23, 2024
@stephan-herrmann
Copy link
Contributor

Unfortunately, it's too late for 4.31, setting milestone as a reminder.

This could actually be a good task for someone who wants to get their feet wet in compiler land, shouldn't be too hard :)

@mpalat mpalat modified the milestones: 4.32 M1, MilestoneNxt Mar 1, 2024
@mpalat mpalat modified the milestones: MilestoneNxt, 4.32 M1 Mar 8, 2024
@stephan-herrmann stephan-herrmann self-assigned this Apr 14, 2024
@stephan-herrmann stephan-herrmann modified the milestones: 4.32 M1, 4.33 M1 Jun 9, 2024
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Jun 9, 2024
@stephan-herrmann
[batch compiler] Unrecognized option : --patch-module
235fcd8 
fixes eclipse-jdt#1895
@stephan-herrmann stephan-herrmann mentioned this issue Jun 9, 2024
Merged
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@stephan-herrmann
[batch compiler] Unrecognized option : --patch-module (eclipse-jdt#2544)
470db4d 
+ implement parsing of the --patch-module option
+ associate affected CUs to the given module
+ detect errors: syntax, duplicates, unresolved module
+ add entry to the -help command line help

Required regression fix :
+ remove project info when removing module-info (JavaModel)

fixes eclipse-jdt#1895
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this issue Sep 7, 2024
@stephan-herrmann @gayanper
[batch compiler] Unrecognized option : --patch-module (eclipse-jdt#2544)
22e2b90 
+ implement parsing of the --patch-module option
+ associate affected CUs to the given module
+ detect errors: syntax, duplicates, unresolved module
+ add entry to the -help command line help

Required regression fix :
+ remove project info when removing module-info (JavaModel)

fixes eclipse-jdt#1895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephan-herrmann stephan-herrmann

Labels
None yet
Projects
None yet
Milestone
4.33 M1
Development

Successfully merging a pull request may close this issue.

[batch compiler] Unrecognized option : --patch-module stephan-herrmann/eclipse.jdt.core
3 participants
@laeubi @mpalat @stephan-herrmann