Loosen slice checking against shape #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterC-DLS
force-pushed
the
loosen-slice-shape-check
branch
3 times, most recently
from
06f3987 to
b43193e
Compare
Switch from checking against source shape to limits of slice, match SliceND and Slice behaviour. Also add unit tests for 100% coverage of those classes and replace fail with assertThrows, and update Tycho to 3.0.5 and target platform to 2020-03 (aka 4.15)
PeterC-DLS
force-pushed
the
loosen-slice-shape-check
branch
from
b43193e to
f9f8418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from checking against source shape to limits of slice, match SliceND and Slice behaviour. Also add units for 100% of those classes and replace fail with assertThrows and update target platform